Patch ping: multiple -o options

Ian Lance Taylor ian@wasabisystems.com
Thu Mar 25 15:31:00 GMT 2004


Nathan Sidwell <nathan@codesourcery.com> writes:

> http://sources.redhat.com/ml/binutils/2004-03/msg00137.html
> 
> In fixing GCC PR driver/13577, I discovered both gas and ld silently
> allow multiple -o options.  This patch fixes that.
> 
> Tested on i686-pc-linux-gnu, and manually for multiple -o usage
> 
> ok?

I think the code in lang_add_output() is too tricky.  I think a future
maintainer is going to have to read that several times to figure out
what is happening, especially given that from_script has type int.
Really the from_script parameter should be bfd_boolean.

The patch to gas is OK.

Ian



More information about the Binutils mailing list