[PATCH] Add sh4-nommu-nofpu architecture

Alexandre Oliva aoliva@redhat.com
Wed Mar 10 06:20:00 GMT 2004


On Mar  9, 2004, amylaar@spamcop.net (Joern Rennecke) wrote:

> Where did we use to return -1?

Err, sorry.  We used to return 7.  I talked Corinna into changing it
to -1 a few days ago, but now I realize her patch wasn't contributed
yet.  And, if your patch goes in, it probably never will (in its
current form, anyway).

> We can return -1 for a nun-match simply by initializing best with -1.

Sounds good enough to me.

> I'm not aware that we need this code anywhere else.  I had put
> the merge macro in the headerfile before only because it was so
> tightly coupled with the numberical values chosen.

And if it's so easy to fail to update the macro, just imagine how
often the update would happen if the code was buried in elf32-sh.c :-)

> Having the code in a into a proper .c file makes debugging much
> easier.  If we really need it somewhere else, we can still move it
> to the header file.

Fair enough.  I don't feel strongly about it either way.

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the Binutils mailing list