[PATCH] Fix movem decoding in m68k disassembler

Andreas Schwab schwab@suse.de
Sun Jul 11 14:30:00 GMT 2004


Nick Clifton <nickc@redhat.com> writes:

> Hi Andreas,
>
>> 2004-06-27  Andreas Schwab  <schwab@suse.de>
>> binutils/testsuite/:
>> 	* binutils-all/m68k/movem.s: New file.
>> 	* binutils-all/m68k/objdump.exp: New file.
>> include/opcode/:
>> 	* m68k.h: Fix comment.
>> opcodes/:
>> 	* m68k-dis.c (m68k_valid_ea): Check validity of all codes.
>> 
>
> Approved - please apply.

Unfortunately insufficient testing didn't let me notice these typos
earlier.  I apologize for the breakage.  Checked in as obvious.

Andreas.

2004-07-11  Andreas Schwab  <schwab@suse.de>

	* m68k-dis.c (m68k_valid_ea): Fix typos in last change.

Index: opcodes/m68k-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/m68k-dis.c,v
retrieving revision 1.15
diff -u -a -p -a -u -p -r1.15 opcodes/m68k-dis.c
--- opcodes/m68k-dis.c	9 Jul 2004 18:42:13 -0000	1.15
+++ opcodes/m68k-dis.c	11 Jul 2004 14:22:19 -0000
@@ -1166,7 +1166,7 @@ m68k_valid_ea (char code, int val)
       mask = M (1,0,1,1,1,1,1,1,1,0,0,0);
       break;
     case '?':
-      mask = M (0,1,0,0,1,1,1,1,1,0,0,0);
+      mask = M (1,0,1,0,0,1,1,1,1,0,0,0);
       break;
     case '/':
       mask = M (1,0,1,0,0,1,1,1,1,1,1,0);
@@ -1175,10 +1175,10 @@ m68k_valid_ea (char code, int val)
       mask = M (0,0,1,0,0,1,1,1,1,1,1,0);
       break;
     case '>':
-      mask = M (0,0,1,0,1,1,1,1,1,1,1,0);
+      mask = M (0,0,1,0,1,1,1,1,1,0,0,0);
       break;
     case '<':
-      mask = M (0,0,1,1,0,1,1,1,1,0,0,0);
+      mask = M (0,0,1,1,0,1,1,1,1,1,1,0);
       break;
     case 'm':
       mask = M (1,1,1,1,1,0,0,0,0,0,0,0);

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Binutils mailing list