[RFA] rda/samples: improve memory allocation
Michael Elizabeth Chastain
Sat Jul 10 03:26:00 GMT 2004
Michael Snyder writes:
+ #define ALLOC_UNIT 0x1000;
Oops, extra semicolon!
+ #define alloc_roundup(LEN) ((LEN / ALLOC_UNIT) + ALLOC_UNIT)
This looks like it's missing a multiplication again by ALLOC_UNIT.
Say, if LEN is 0x3000, then alloc_roundup(LEN) comes out to 0x1003
which seems weird.
#define alloc_roundup(LEN) ((((LEN)+ALLOC_UNIT-1) / ALLOC_UNIT) * ALLOC_UNIT)
Or I dunno exactly what you want, but that definition doesn't look
right. Looks like a missing call to alloc_coffee somewhere ...
More information about the Binutils