PATCH: Return NULL on NULL bfd (Problem with linker with binutils-040414)

Nick Clifton nickc@redhat.com
Tue Apr 20 09:04:00 GMT 2004


Hi H. J.

>How about this patch?
>
>
>H.J.
>----
>2004-04-19  H.J. Lu  <hongjiu.lu@intel.com>
>
>	* bfd.c (bfd_archive_filename): Return NULL on NULL bfd.
>
>  
>
This version of your patch (returning NULL) is approved for the 
mainline, and I suspect that Daniel will approve it for the branch.

I agree that returning a NULL here can delay the detection of a problem, 
but that will be because of poor coding (ie not checking the return 
value of bfd_archive_filename) and in such cases the programmer gets 
what they deserve.

Cheers
  Nick



More information about the Binutils mailing list