[PATCH] Support DWARF 2/3 on i?86 PE

Alan Modra amodra@bigpond.net.au
Sat Apr 17 11:29:00 GMT 2004


On Fri, Apr 16, 2004 at 10:20:18AM -0500, Brian Ford wrote:
> I assume you mean remove the leading * from the second line and end with
> two spaces before the */?  Sorry,  I know better.  But, I wanted to
> clarify and make sure I wasn't missing anything else.

Yes, that was all that was wrong with the formatting.

> > Hmm, actually the comment is wrong.  You want:
> >
> > 	/* The first non-zero section filepos is the header size.
> > 	   Sections without contents will have a filepos of 0.  */
> 
> I agree that says *approximately* the same thing, so I have changed it
> accordingly.  But, I still don't understand why you think the original
> comment was wrong?
> 
> "Orphaned and alloc only sections may have a filepos of 0."
> 
> Orphaned sections may have contents.  They just don't end up in the output
> file.  Also, alloc only implies no contents.

The comment as I wrote it states a stronger condition.  The part that
was wrong in the original comment was the implication that orphan
sections are special.  They aren't, apart from (by definition) not being
mentioned in the linker script.  Whether they have a filepos or not has
no particular relation to them being orphan sections.

> Ok, but as I said in a previous email, I don't have a sources.redhat.com
> account, or binutils write access.  Did you want to check these two in, or
> do you want to "sponsor" me for "Write After Approval" access?  I'll
> submit the appropriate form if so.

I'll check them in, and you can also apply for write after approval with
me as sponsor.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list