[PATCH] Fix for ldm/stm instructions in H8S

Richard Sandiford rsandifo@redhat.com
Wed Nov 26 10:56:00 GMT 2003


Nick Clifton <nickc@redhat.com> writes:
> Hi Asgari,
> > I have modified patch for H8S and H8SX targets. Also I have created
> > patches for multiples.s and h8300.exp in gas/h8300 testsuite. This
> > was tested with binutils-031111 testsuite and found okay.
> 
> Thanks very much - this patch is much better.  There was one small
> omission - the h8300 testcase t01_mov.s had a couple of illegal
> register pairings in it, which lead to an extra 78 unexpected failures
> when the gas testsuite was run for the h8300-elf toolchain.
> 
> I have applied your patch together with a fix to t01_mov.s and
> t01_mov.exp so that there are no new testsuite failures.

Hmm, I see the changes you made are the ones below.  Are you sure
that's right?  My understanding was that r4-r7 was a valid sequence
on the H8SX.  I think the tech note only applies to the H8S.

Richard


Index: t01_mov.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/h8300/t01_mov.s,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- t01_mov.s	5 Jun 2003 18:52:00 -0000	1.1
+++ t01_mov.s	25 Nov 2003 16:13:36 -0000	1.2
@@ -1067,7 +1067,7 @@
     ldm @sp+,(er1-er4)                  ;01306d74
     ldm @sp+,(er2-er5)                  ;01306d75
     ldm @sp+,(er3-er6)                  ;01306d76
-    ldm @sp+,(er4-er7)                  ;01306d77
+    ldm @sp+,(er5-er7)                  ;01206d77
 
     stm (er0-er1),@-sp                  ;01106df0
     stm (er1-er2),@-sp                  ;01106df1
@@ -1088,7 +1088,7 @@
     stm (er1-er4),@-sp                  ;01306df1
     stm (er2-er5),@-sp                  ;01306df2
     stm (er3-er6),@-sp                  ;01306df3
-    stm (er4-er7),@-sp                  ;01306df4
+    stm (er5-er7),@-sp                  ;01206df5
 
     eepmov.b                            ;7b5c598f
 



More information about the Binutils mailing list