[patch] Automake install-info problem in gas/

Maciej W. Rozycki macro@ds2.pg.gda.pl
Mon Nov 17 14:52:00 GMT 2003


On Mon, 3 Nov 2003, Daniel Jacobowitz wrote:

> >From the conversion to automake 1.7, rather.  This patch fixes it
> although I'm not terribly happy overriding install or referencing
> RECURSIVE_TARGETS.  I've attached a patch, including changes to
> generated files so that you can see what I mean.
> 
> The gist of the problem is that AUTOMAKE_OPTIONS = cygnus now overrides
> more than it used to in texinfos.am.
> 
> Does anyone see a better way?  If not, I'll commit this.

 I've missed your mail and I see you've applied the patch since.  This is
obviously a bug in automake (which crept in around 1.5 and remained
unnoticed till now) and I've sent report with proposed fixes to the
automake maintainers.  A fix for the 1.7 branch is included below.  Your
workaround seems to work, but it's ugly and leads to a failure of
automake:

Makefile.am:463: RECURSIVE_TARGETS must be set with `=' before using `+='

with the exit status being set to 1.

 I propose to revert your patch once automake is fixed and require the
fixed version of automake for 2.15.  What do you think?

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

automake-1.7.8-install-info.patch
diff -up --recursive --new-file automake-1.7.8.macro/lib/am/texinfos.am automake-1.7.8/lib/am/texinfos.am
--- automake-1.7.8.macro/lib/am/texinfos.am	2003-10-03 08:55:45.000000000 +0000
+++ automake-1.7.8/lib/am/texinfos.am	2003-11-10 23:49:48.000000000 +0000
@@ -104,13 +104,13 @@ if %?LOCAL-TEXIS%
 am__installdirs += $(DESTDIR)$(infodir)
 install-data-am: install-info-am
 endif %?LOCAL-TEXIS%
+endif %?INSTALL-INFO%
 if %?SUBDIRS%
 RECURSIVE_TARGETS += install-info-recursive
 .PHONY install-info: install-info-recursive
 else !%?SUBDIRS%
 install-info: install-info-am
 endif !%?SUBDIRS%
-endif %?INSTALL-INFO%
 
 .PHONY: install-info-am
 



More information about the Binutils mailing list