forwarded message from H. J. Lu
H. J. Lu
hjl@lucon.org
Wed May 21 17:33:00 GMT 2003
On Wed, May 21, 2003 at 01:04:50PM -0400, John David Anglin wrote:
> > We know exactly what changed.
>
> Alan, thanks for the pointer.
>
> I believe that the enclosed patch will fix the whitespace problem.
> I have removed `,' and `!' from hppa_symbol_chars. `,' is a separator
> in the opcode and operand fields. It should never be followed by
> meaningful whitespace. The same is true for `!'. When used in
> a completor, it is never the last character of the completor. It
> is also used as a statement separator. When used as a statement
> separator, there is never a label field, so there can't be any
> meaningful whitespace after it. So, as I understand it, any
> whitespace after a comma or exclamation will now be removed by the
> scrubber. This restores the previous behavior of accepting whitespace
> after commas. For other situations like `=', we don't allow whitespace
> removal. This could have been a problem for various floating point
> conditions which end in `='.
>
> I have tested this on hppa-linux, hppa2.0w-hp-hpux11.11 and
> hppa64-hp-hpux11.11. I have a gcc build running on hppa-linux
> and so far there are no problems.
>
> Does this look reasonable?
>
Please also add some testcases.
H.J.
More information about the Binutils
mailing list