[PATCH] CFI directives for GAS

[Zack Weinberg]

Hans-Peter Nilsson <hp@bitrange.com> writes:

> On Thu, 15 May 2003, Michal Ludvig wrote:
>> For now the architectures that have these new directives enabled are
>> i386 and amd64.
>>
>> Commented example on the usage can be found here:
>> http://www.logix.cz/~mic/devel/gas-cfi/example.s.html
>>
>> How do you like this idea? Any comments? Can I apply the patch?
>
> You asked for comments, so here goes my usual knee-jerk
> reaction: Cool, but how do we know this works and doesn't
> trivially break with anyone's next set of patches?  Where's the
> test-suite?  Even one i386 or amd64-specific case from your
> example code would be terrific.  Consider that test-cases for
> new features are mandatory in GCC, and for IMHO a good reason.

Also, you didn't add any documentation.  GAS already has too many
undocumented directives.

zw