PATCH: don't sign-extend address in ihex files

Alan Modra amodra@bigpond.net.au
Wed May 14 09:13:00 GMT 2003


On Tue, May 13, 2003 at 03:03:09PM -0500, Jim Blandy wrote:
> Since the value of the hex_value
> macro (defined in libiberty.h) is signed

Except when char is unsigned, which is another argument in favour of
your patch.

> 2003-05-07  Jim Blandy  <jimb@redhat.com>
> 
> 	* ihex.c (NIBBLE): Make this unsigned, to avoid sign-extension
> 	when the value of a HEX2 or HEX4 application gets stored in a
> 	64-bit bfd_vma.

OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list