PATCH; Don't return FALSE for undefined symbols

H. J. Lu hjl@lucon.org
Sat Mar 22 03:03:00 GMT 2003


There is no need to do that. Most of ELF targets don't. We have told
undefined_symbol if the error is fatal.


H.J.
---
2003-03-21  H.J. Lu <hjl@gnu.org>

	* elf64-alpha.c (elf64_alpha_relocate_section): Don't return
	FALSE for undefined symbols.
	* elfxx-ia64.c (elfNN_ia64_relocate_section): Likewise.

--- bfd/elf64-alpha.c.undefined	2003-02-27 11:26:59.000000000 -0800
+++ bfd/elf64-alpha.c	2003-03-21 15:40:45.000000000 -0800
@@ -4514,7 +4514,6 @@ elf64_alpha_relocate_section (output_bfd
 		     (!info->shared || info->no_undefined
 		      || ELF_ST_VISIBILITY (h->root.other)))))
 		return FALSE;
-	      ret_val = FALSE;
 	      continue;
 	    }
 
--- bfd/elfxx-ia64.c.undefined	2003-03-21 08:35:45.000000000 -0800
+++ bfd/elfxx-ia64.c	2003-03-21 15:41:28.000000000 -0800
@@ -3953,7 +3953,6 @@ elfNN_ia64_relocate_section (output_bfd,
 		      (!info->shared || info->no_undefined
 		       || ELF_ST_VISIBILITY (h->other)))))
 		return FALSE;
-	      ret_val = FALSE;
 	      continue;
 	    }
 	}



More information about the Binutils mailing list