objcopy.c: question regarding debugging info handling

[Alan Modra]

On Mon, Mar 03, 2003 at 12:49:53PM +0100, Joerg Wunsch wrote:
> I'm wondering
> about the following piece in objcopy.c::filter_symbols():
> 
>       else if ((flags & BSF_DEBUGGING) != 0)	/* Debugging symbol.  */
> 	keep = (strip_symbols != STRIP_DEBUG
> 		&& strip_symbols != STRIP_UNNEEDED
> 		&& ! convert_debugging);
> 
> This will make a symbol from the symtab go away that is marked as
> BSF_DEBUGGING even though convert_debugging is true.  Shouldn't that
> be
> 
> 	keep = (strip_symbols != STRIP_DEBUG
> 		&& strip_symbols != STRIP_UNNEEDED)
> 	       || convert_debugging;
> 
> instead, i. e. when convert_debugging is true, BSF_DEBUGGING symbols
> should always be kept?

I think the idea was that write_debugging_info should add used debug
symbols back.  Obviously, it doesn't do so yet.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre