[patch RFA] revisit MIPS warning re: global symbols as branch targets.

[Thiemo Seufer]

cgd@broadcom.com wrote:
> At Tue, 1 Jul 2003 23:15:44 +0200, Thiemo Seufer wrote:
> > cgd@broadcom.com wrote:
> > [snip]
> > > --- config/tc-mips.c	30 Jun 2003 21:54:19 -0000	1.224
> > > +++ config/tc-mips.c	1 Jul 2003 17:21:54 -0000
> > > @@ -11059,8 +11059,9 @@ mips_validate_fix (struct fix *fixP, ase
> > >  	{
> > >  	  symbolS *sym = fixP->fx_addsy;
> > >  
> > > -	  as_warn_where (fixP->fx_file, fixP->fx_line,
> > > -			 _("Pretending global symbol used as branch target is local."));
> > > +	  if (mips_pic != NO_PIC)
> > > +	    as_warn_where (fixP->fx_file, fixP->fx_line,
> > > +			   _("Pretending global symbol used as branch target is local."));
> > 
> > if (mips_pic == SVR4_PIC) is probably enough.
> 
> Is that "approved if you make that change and test it"?  or other?
> 8-)

Yes, it is approved with that change.
Seems like Eric leaves all the work to me now. :-)


Thiemo