[discussion/patch] use mkstemps/mkdtemps instead of mktemp.

DJ Delorie dj@delorie.com
Thu Jul 3 22:26:00 GMT 2003


> 1. Added mkdtemps to libiberty. Its same as mkstemps except it uses MKDIR
> to create directory.

Logistics of the patch aside, I have a few comments:

libiberty patches must also be sent to gcc-patches@gcc.gnu.org

> /* Copyright (C) 1991, 1992, 1996, 1998 Free Software Foundation, Inc.

These years are obviously wrong.

> #if defined (_WIN32) && !defined (__CYGWIN32__)

I believe the correct symbol to test is __CYGWIN__

> Generate a unique temporary file name from @var{template}.

A unique temporary *directory* name.

> 	/* The file does not exist.  */

file -> directory
does -> did



More information about the Binutils mailing list