[PATCH] TLS support for s390*.

Jakub Jelinek jakub@redhat.com
Sat Jan 25 00:01:00 GMT 2003


On Fri, Jan 24, 2003 at 03:35:45PM +0100, Martin Schwidefsky wrote:
> +	  if (nbytes == 2)
> +	    {
> +	      static bfd_reloc_code_real_type tab2[] =
> +		{
> +		  [ELF_SUFFIX_NONE] BFD_RELOC_UNUSED ,
> +		  [ELF_SUFFIX_GOT] BFD_RELOC_390_GOT16,
> +		  [ELF_SUFFIX_PLT] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_GOTENT] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_GOTOFF] BFD_RELOC_16_GOTOFF,
> +		  [ELF_SUFFIX_GOTPLT] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_PLTOFF] BFD_RELOC_390_PLTOFF16,
> +		  [ELF_SUFFIX_TLS_GD] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_TLS_GOTIE] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_TLS_IE] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_TLS_LDM] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_TLS_LDO] BFD_RELOC_UNUSED,
> +		  [ELF_SUFFIX_TLS_LE] BFD_RELOC_UNUSED,
> +		};

Are designated initializers allowed in binutils code
(and even if they were, it ought to be ISO C99 syntax, not the
GCC extension, ie. [ELF_SUFFIX_GOT] = BFD_RELOC_390_GOT16)?

When you list all the enum values anyway, I think it should just
be changed into comments.

	Jakub



More information about the Binutils mailing list