RFC/RFT: split up pexecute.c

Christopher Faylor cgf@redhat.com
Fri Jan 24 21:44:00 GMT 2003


On Fri, Jan 24, 2003 at 04:38:55PM -0500, DJ Delorie wrote:
>
>> You mean a patch to put it back the way it was before?  Previously,
>> although there was a CYGWIN conditional in pexecute.c it was not
>> actually used in the normal case unless the user specifically defined
>> _WIN32.  Perhaps, that's not an ideal situation but this change
>> introduces a change in behavior for cygwin since it is now exercising
>> code that previously had not been commonly used.
>
>Oh, I thought you meant you were going to get around to fixing the
>code.  Yes, that does sound confusing.  Why wasn't the obsolete code
>removed "back when" ?

Nothing was broken and it wasn't a priority.  I was planning on removing
the code "someday".

>Sounds like just configure.in needs a tweak, then?

Yes.  And a "cvs remove -f pex-cygwin.c".

I'm building a native compile now but I don't think the below patch will
cause any problems.

cgf

2003-01-24  Christopher Faylor  <cgf@redhat.com>

        * configure.in: Remove special pex-cygwin consideration.
        * configure: Regenerate.
        * pex-cygwin.c: Remove.

Index: configure.in
===================================================================
RCS file: /cvs/uberbaum/libiberty/configure.in,v
retrieving revision 1.53
diff -u -p -r1.53 configure.in
--- configure.in	24 Jan 2003 20:02:11 -0000	1.53
+++ configure.in	24 Jan 2003 21:41:24 -0000
@@ -427,7 +427,6 @@ fi
 
 # Figure out which version of pexecute to use.
 case "${host}" in
-     *-*-cygwin*)		pexecute=pex-cygwin.o ;;
      *-*-mingw* | *-*-winnt*)	pexecute=pex-win32.o  ;;
      *-*-msdosdjgpp*)		pexecute=pex-djgpp.o  ;;
      *-*-msdos*)		pexecute=pex-msdos.o  ;;



More information about the Binutils mailing list