PATCH: Fix demangler in symbol versioning

[Daniel Jacobowitz]

On Thu, Dec 04, 2003 at 03:59:08PM -0500, Ian Lance Taylor wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> 
> > -      cxx_sym = cplus_demangle (sym, /* DMGL_NO_TPARAMS */ 0);
> > +      cxx_sym = cplus_demangle (sym, (DMGL_PARAMS
> > +				      | DMGL_ANSI
> > +				      | DMGL_VERBOSE));
> 
> I doubt you need DMGL_VERBOSE here, and I would recommend against it.
> 
> >    if (head->mask & BFD_ELF_VERSION_JAVA_TYPE)
> >      {
> > -      java_sym = cplus_demangle (sym, DMGL_JAVA);
> > +      java_sym = java_demangle_v3 (sym);
> >        if (!java_sym)
> >  	java_sym = sym;
> >      }
> 
> I'm puzzled as to how this could ever have worked.  I think you can
> only demangle Java via cplus_demangle() if you call
> cplus_demangle_set_style().  But perhaps I am missing something.

I am fairly certain it used to work.  A change here might explain
problems Ulrich Weigand saw in the GDB Java testsuite...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer