windres: serious bug

[Nick Clifton]

Hi Danny,

> > PS.  I created the dialogid.rsd file using windres rather than
> > Window's resource compiler because I do not have access to a Windows
> > build system.  If anyone does have such access and can check that the
> > compiled dialogid.rc file really does match with the one I created,
> > (modulo the "Static" discrepancy), I would be very grateful.
> >
>  I can confirm that.
> If you change "Static" to "classname" in the testcase, than the rc vs
> windres dumps are identical.

Thanks.  I have applied the patch below to make this change.

Cheers
        Nick

2003-04-03  Nick Clifton  <nickc@redhat.com>

	* binutils-all/windres/dialogid.rc: Replace "Static" with
	"classname" so that compilation will match behaviour of the
	Windows resource compiler.

Index: binutils-all/windres/dialogid.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/dialogid.rc,v
retrieving revision 1.1
diff -c -3 -p -w -r1.1 dialogid.rc
*** binutils-all/windres/dialogid.rc	31 Mar 2003 10:15:58 -0000	1.1
--- binutils-all/windres/dialogid.rc	3 Apr 2003 10:45:29 -0000
***************
*** 4,9 ****
  101 DIALOGEX 0, 0, 200, 200
  
  BEGIN
! CONTROL 108, -1, "Static", 77, 11, 11, 83, 162
! CONTROL "stringid", 102, "Static", 0x5000120e, 5, 5, 10, 10
  END
--- 4,9 ----
  101 DIALOGEX 0, 0, 200, 200
  
  BEGIN
! CONTROL 108, -1, "classname", 77, 11, 11, 83, 162
! CONTROL "stringid", 102, "classname", 0x5000120e, 5, 5, 10, 10
  END

Index: binutils-all/windres/dialogid.rsd
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/dialogid.rsd,v
retrieving revision 1.1
diff -c -3 -p -w -r1.1 dialogid.rsd
*** binutils-all/windres/dialogid.rsd	31 Mar 2003 10:15:58 -0000	1.1
--- binutils-all/windres/dialogid.rsd	3 Apr 2003 10:45:29 -0000
***************
*** 1,13 ****
   0000 00000000 20000000 ffff0000 ffff0000  .... ...........
   0010 00000000 00000000 00000000 00000000  ................
!  0020 86000000 20000000 ffff0500 ffff6500  .... .........e.
   0030 00000000 30100904 00000000 00000000  ....0...........
   0040 0100ffff 00000000 00000000 00008880  ................
   0050 02000000 0000c800 c8000000 00000000  ................
   0060 00000000 00000000 4d000050 0b000b00  ........M..P....
!  0070 5300a200 ffff0000 53007400 61007400  S.......S.t.a.t.
!  0080 69006300 0000ffff 6c000000 00000000  i.c.....l.......
!  0090 00000000 0e120050 05000500 0a000a00  .......P........
!  00a0 66000000 53007400 61007400 69006300  f...S.t.a.t.i.c.
!  00b0 00007300 74007200 69006e00 67006900  ..s.t.r.i.n.g.i.
!  00c0 64000000 00000000                    d.......        
--- 1,18 ----
+ 
+ fred.res:     file format binary
+ 
+ Contents of section .data:
   0000 00000000 20000000 ffff0000 ffff0000  .... ...........
   0010 00000000 00000000 00000000 00000000  ................
!  0020 94000000 20000000 ffff0500 ffff6500  .... .........e.
   0030 00000000 30100904 00000000 00000000  ....0...........
   0040 0100ffff 00000000 00000000 00008880  ................
   0050 02000000 0000c800 c8000000 00000000  ................
   0060 00000000 00000000 4d000050 0b000b00  ........M..P....
!  0070 5300a200 ffff0000 63006c00 61007300  S.......c.l.a.s.
!  0080 73006e00 61006d00 65000000 ffff6c00  s.n.a.m.e.....l.
!  0090 00000000 00000000 00000000 0e120050  ...............P
!  00a0 05000500 0a000a00 66000000 63006c00  ........f...c.l.
!  00b0 61007300 73006e00 61006d00 65000000  a.s.s.n.a.m.e...
!  00c0 73007400 72006900 6e006700 69006400  s.t.r.i.n.g.i.d.
!  00d0 00000000                             ....