Committed: Fix for bfd/simple.c

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Fri Oct 25 08:43:00 GMT 2002


My autobarfer build horked with gcc-2.95.2.  Presumably because
naked attributes aren't allowed on types in prototypes or
something.  Adding parameter names in the prototypes let
compilation finish, but the attributes were non-functional so
there were the obvious warnings.  Anyway, attribute placement
should have been as is done elsewhere.  Committed as obvious.

bfd:
	* simple.c: Correct placement of ATTRIBUTE_UNUSED.

Index: simple.c
===================================================================
RCS file: /cvs/src/src/bfd/simple.c,v
retrieving revision 1.2
diff -c -p -r1.2 simple.c
*** simple.c	25 Oct 2002 03:19:29 -0000	1.2
--- simple.c	25 Oct 2002 15:33:20 -0000
***************
*** 25,80 ****
  #include "bfdlink.h"
  
  static boolean simple_dummy_warning
!   PARAMS ((struct bfd_link_info * ATTRIBUTE_UNUSED,
! 	   const char * ATTRIBUTE_UNUSED, const char * ATTRIBUTE_UNUSED,
! 	   bfd * ATTRIBUTE_UNUSED, asection * ATTRIBUTE_UNUSED,
! 	   bfd_vma ATTRIBUTE_UNUSED));
  
  static boolean simple_dummy_undefined_symbol
!   PARAMS ((struct bfd_link_info * ATTRIBUTE_UNUSED,
! 	   const char * ATTRIBUTE_UNUSED, bfd * ATTRIBUTE_UNUSED,
! 	   asection * ATTRIBUTE_UNUSED, bfd_vma ATTRIBUTE_UNUSED,
! 	   boolean ATTRIBUTE_UNUSED));
  
  static boolean simple_dummy_reloc_overflow 
!   PARAMS ((struct bfd_link_info * ATTRIBUTE_UNUSED,
! 	   const char * ATTRIBUTE_UNUSED, const char * ATTRIBUTE_UNUSED,
! 	   bfd_vma ATTRIBUTE_UNUSED, bfd * ATTRIBUTE_UNUSED,
! 	   asection * ATTRIBUTE_UNUSED, bfd_vma ATTRIBUTE_UNUSED));
  
  static boolean simple_dummy_reloc_dangerous
!   PARAMS ((struct bfd_link_info * ATTRIBUTE_UNUSED,
! 	   const char * ATTRIBUTE_UNUSED, bfd * ATTRIBUTE_UNUSED,
! 	   asection * ATTRIBUTE_UNUSED, bfd_vma ATTRIBUTE_UNUSED));
  
  static boolean simple_dummy_unattached_reloc
!   PARAMS ((struct bfd_link_info * ATTRIBUTE_UNUSED,
! 	   const char * ATTRIBUTE_UNUSED, bfd * ATTRIBUTE_UNUSED,
! 	   asection * ATTRIBUTE_UNUSED, bfd_vma ATTRIBUTE_UNUSED));
  
  bfd_byte * bfd_simple_get_relocated_section_contents
    PARAMS ((bfd *, asection *, bfd_byte *));
  
  static boolean
  simple_dummy_warning (link_info, warning, symbol, abfd, section, address)
!      struct bfd_link_info *link_info;
!      const char *warning;
!      const char *symbol;
!      bfd *abfd;
!      asection *section;
!      bfd_vma address;
  {
    return true;
  }
  
  static boolean
  simple_dummy_undefined_symbol (link_info, name, abfd, section, address, fatal)
!      struct bfd_link_info *link_info;
!      const char *name;
!      bfd *abfd;
!      asection *section;
!      bfd_vma address;
!      boolean fatal;
  {
    return true;
  }
--- 25,70 ----
  #include "bfdlink.h"
  
  static boolean simple_dummy_warning
!   PARAMS ((struct bfd_link_info *, const char *, const char *, bfd *,
! 	   asection *, bfd_vma));
  
  static boolean simple_dummy_undefined_symbol
!   PARAMS ((struct bfd_link_info *, const char *, bfd *, asection *,
! 	   bfd_vma, boolean));
  
  static boolean simple_dummy_reloc_overflow 
!   PARAMS ((struct bfd_link_info *, const char *, const char *, bfd_vma,
! 	   bfd *, asection *, bfd_vma));
  
  static boolean simple_dummy_reloc_dangerous
!   PARAMS ((struct bfd_link_info *, const char *, bfd *, asection *, bfd_vma));
  
  static boolean simple_dummy_unattached_reloc
!   PARAMS ((struct bfd_link_info *, const char *, bfd *, asection *, bfd_vma));
  
  bfd_byte * bfd_simple_get_relocated_section_contents
    PARAMS ((bfd *, asection *, bfd_byte *));
  
  static boolean
  simple_dummy_warning (link_info, warning, symbol, abfd, section, address)
!      struct bfd_link_info *link_info ATTRIBUTE_UNUSED;
!      const char *warning ATTRIBUTE_UNUSED;
!      const char *symbol ATTRIBUTE_UNUSED;
!      bfd *abfd ATTRIBUTE_UNUSED;
!      asection *section ATTRIBUTE_UNUSED;
!      bfd_vma address ATTRIBUTE_UNUSED;
  {
    return true;
  }
  
  static boolean
  simple_dummy_undefined_symbol (link_info, name, abfd, section, address, fatal)
!      struct bfd_link_info *link_info ATTRIBUTE_UNUSED;
!      const char *name ATTRIBUTE_UNUSED;
!      bfd *abfd ATTRIBUTE_UNUSED;
!      asection *section ATTRIBUTE_UNUSED;
!      bfd_vma address ATTRIBUTE_UNUSED;
!      boolean fatal ATTRIBUTE_UNUSED;
  {
    return true;
  }
*************** simple_dummy_undefined_symbol (link_info
*** 82,116 ****
  static boolean
  simple_dummy_reloc_overflow (link_info, name, reloc_name, addend, abfd,
  			     section, address)
!      struct bfd_link_info *link_info;
!      const char *name;
!      const char *reloc_name;
!      bfd_vma addend;
!      bfd *abfd;
!      asection *section;
!      bfd_vma address;
  {
    return true;
  }
  
  static boolean
  simple_dummy_reloc_dangerous (link_info, message, abfd, section, address)
!      struct bfd_link_info *link_info;
!      const char *message;
!      bfd *abfd;
!      asection *section;
!      bfd_vma address;
  {
    return true;
  }
  
  static boolean
  simple_dummy_unattached_reloc (link_info, name, abfd, section, address)
!      struct bfd_link_info *link_info;
!      const char *name;
!      bfd *abfd;
!      asection *section;
!      bfd_vma address;
  {
    return true;
  }
--- 72,106 ----
  static boolean
  simple_dummy_reloc_overflow (link_info, name, reloc_name, addend, abfd,
  			     section, address)
!      struct bfd_link_info *link_info ATTRIBUTE_UNUSED;
!      const char *name ATTRIBUTE_UNUSED;
!      const char *reloc_name ATTRIBUTE_UNUSED;
!      bfd_vma addend ATTRIBUTE_UNUSED;
!      bfd *abfd ATTRIBUTE_UNUSED;
!      asection *section ATTRIBUTE_UNUSED;
!      bfd_vma address ATTRIBUTE_UNUSED;
  {
    return true;
  }
  
  static boolean
  simple_dummy_reloc_dangerous (link_info, message, abfd, section, address)
!      struct bfd_link_info *link_info ATTRIBUTE_UNUSED;
!      const char *message ATTRIBUTE_UNUSED;
!      bfd *abfd ATTRIBUTE_UNUSED;
!      asection *section ATTRIBUTE_UNUSED;
!      bfd_vma address ATTRIBUTE_UNUSED;
  {
    return true;
  }
  
  static boolean
  simple_dummy_unattached_reloc (link_info, name, abfd, section, address)
!      struct bfd_link_info *link_info ATTRIBUTE_UNUSED;
!      const char *name ATTRIBUTE_UNUSED;
!      bfd *abfd ATTRIBUTE_UNUSED;
!      asection *section ATTRIBUTE_UNUSED;
!      bfd_vma address ATTRIBUTE_UNUSED;
  {
    return true;
  }

brgds, H-P



More information about the Binutils mailing list