K&R patch for binutils bfd directory

Alan Modra amodra@bigpond.net.au
Thu Oct 24 19:12:00 GMT 2002


On Thu, Oct 24, 2002 at 07:00:18PM -0400, John David Anglin wrote:
> This may be a losing battle but here is the K&R patch for the bfd directory.
> I am sure that the addition of simple.c breaks building with the HP bundled
> compiler.  There are a few changes that may fix real bugs (aoutx.h).
> 
> Tested on vax-dec-ultrix4.3.
> 
> Ok?

OK.  It offends my sense of style to see something like

	copy = (boolean) (! finfo->info->keep_memory);

but one alternative 

	copy = ! finfo->info->keep_memory ? true : false;

looks almost as silly to me.  I went through bfd a while back removing
some occurrences of the second idiom, and also comparisions against true
or false, not realizing I was breaking K&R compiles.  Sorry.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list