mips: branches to external labels are broken

[Alexandre Oliva]

On Nov 27, 2002, Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> wrote:

>> There's no reason to assume so.  The hack becomes pointless (and
>> wrong) when we do RELA instead of REL.  EMBEDDED_PIC has nothing to do
>> with RELAness, it's HAVE_NEWABI that does, so that's the right test.

> NewABI has no BFD_RELOC_16_PCREL_S2 relocation. A test for
> HAVE_NEWABI there is at least misleading.

A test for EMBEDDED_PIC would be even more so.

>> I don't know that EMBEDDED_PIC and NEWABI are incompatible, and I
>> don't really care.  EMBEDDED_PIC is not the right test there, since
>> the real test to be done is whether the addend is going to be
>> installed in place or not.

> What about checking the howto for partial_inplace then?

Sure, that works just as well.  It's just a more expensive way to test
for the same result.  If you prefer that, well, feel free...  I still
haven't seen a reason to change the patch, other than, perhaps, adding
comments to clarify why it's being tested like that.

> Or simply rely on the fact that there is no howto without
> partial_inplace for BFD_RELOC_16_PCREL_S2, IOW don't do this check
> at all.

Then someone adds the reloc in the future and has to untangle the mess
again.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer