binutils is broken for Linux/sh

Alan Modra amodra@bigpond.net.au
Thu Nov 21 01:01:00 GMT 2002


On Thu, Nov 21, 2002 at 03:37:59AM -0500, Klee Dienes wrote:
> 	* config/tc-mcore.c (md_begin): Use a const iterator, not a
> 	non-const.  Don't coalesce the name fields to use the same pointer
> 	(the struct is no longer writable, and we only reference it with
> 	strcmp anyway).
> 
> 	* config/tc-sh.c (md_begin): Use a const iterator, not a
> 	non-const.  Don't coalesce the name fields to use the same pointer
> 	(the struct is no longer writable).
> 	(get_specific): Check for opcodes with the same name using strcmp
> 	as well as comparing the pointer.  This code should generally
> 	never be used, as the compiler will generally merge identical
> 	constant strings to have the same address.

OK, but ChangeLog entries don't need all the explanation.

	* config/tc-mcore.c (md_begin): Use a const iterator.  Don't
	coalesce the name fields to use the same pointer.

	* config/tc-sh.c (md_begin): Use a const iterator.  Don't coalesce
	the name fields to use the same pointer.
	(get_specific): Check for opcodes with the same name using strcmp
	as well as comparing the pointer.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list