revised linker testsuite patch

Scott Bambrough sbambrough@storm.ca
Fri Nov 8 12:14:00 GMT 2002


I withdraw my earlier patch for this file and submit this new one.  As
Alan pointed out the syntax used was not documented, though it works.

After discussion with Richard, Phil and Nick, it was decided the ELF
backend in GCC was in error, and should be changed to match the 
NetBSD behaviour.  Richard has since committed a change to do this.

I'd like to change the syntax used in this file as the '@' is the 
comment character in ARM assembler, causing this file to be assembled
incorrectly.

If this is ok, could someone please commit this.  I don't seem to have
write access to the tree anymore.

Scott


2002-11-06  Scott Bambrough  <scottb@netwinder.org>

        * ld-elfvsb/define.s: Use different syntax for .type directive.
        The @ is the comment character in ARM assembler.

--- src.orig/ld/testsuite/ld-elfvsb/define.s    Mon Nov 19 15:32:02 2001
+++ src/ld/testsuite/ld-elfvsb/define.s Wed Oct 30 21:01:17 2002
@@ -1,10 +1,10 @@
        .data
        .globl protected
-       .type protected,@object
+       .type protected,%object
 protected:
        .globl hidden
-       .type hidden,@object
+       .type hidden,%object
 hidden:
        .globl internal
-       .type internal,@object
+       .type internal,%object
 internal:

The above patch fixes the following testsuite errors on ARM Linux.

Running /home/cvs/src.orig/ld/testsuite/ld-elfvsb/elfvsb.exp ...
FAIL: ld-elfvsb/hidden0
FAIL: ld-elfvsb/internal0
FAIL: ld-elfvsb/protected0


-- 
Scott Bambrough <sbambrough@storm.ca>
-------------- next part --------------
--- src.orig/ld/testsuite/ld-elfvsb/define.s	Mon Nov 19 15:32:02 2001
+++ src/ld/testsuite/ld-elfvsb/define.s	Fri Nov  8 14:53:13 2002
@@ -1,10 +1,10 @@
 	.data
 	.globl protected
-	.type protected,@object
+	.type protected,%object
 protected:
 	.globl hidden
-	.type hidden,@object
+	.type hidden,%object
 hidden:
 	.globl internal
-	.type internal,@object
+	.type internal,%object
 internal:


More information about the Binutils mailing list