[PATCH] pei386: make --enable-auto-import default

Nick Clifton nickc@cambridge.redhat.com
Fri May 31 02:50:00 GMT 2002


Hi Charles,

  Umm - my records do not show a binutils copyright assignment from
  you.  Without such an assignment we really cannot accept patches to
  binutils. :-(

> -  link_info.pei386_auto_import = false;
> +  link_info.pei386_auto_import = -1; /* 0=disable 1=enable */

  I think that you should document what the -1 value means as well.


> -              einfo (_("Warning: resolving %s by linking to %s (auto-import)\n"),
> +              if (link_info.pei386_auto_import == -1)
> +              {
> +                info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
>                       undef->root.string, buf);
> +              }

  You can drop the curly parentheses because there is only one statement
  inside the block.

Cheers
        Nick



More information about the Binutils mailing list