[PATCH] Fix MIPS gas no-mfix7000 commandline option

[Thiemo Seufer]

Eric Christopher wrote:
> On Thu, 2002-05-30 at 14:44, cgd@broadcom.com wrote:
> > At Thu, 30 May 2002 21:24:40 +0000 (UTC), "Eric Christopher" wrote:
> > > > This is where I'm confused.  Don't you mean -mFOO -> -mno-FOO?
> 
> > 
> > "Eh."
> > 
> > Would it really be that bad to do the rename, deprecate the old
> > options but keep them around for a release, etc., assuming somebody
> > else were willing to do the work?  I.e., if somebody were to do the
> > work for MIPS, would you reject the patch?  8-)
> 
> Nah. If you, Daniel or Thiemo want to do it for the syntax above I'll
> happily accept it :)

I tried to, but I didn't get far:

For options with arguments a complementary makes no sense.
Many options like -membedded-pic have no complementary form.
-trap/-no-break and -break/-no-trap have different style anyway.
-mpf32/-mgp32 use -*64 form, which IIRC aren't real inverses.
-mips16/-no-mips16 would be more confusing than it is now, same for
	-mips3d/-no-mips3d.
-construct-floats/-no-construct-floats has no -m prefix.
-mXXXX for cpu selection are deprecated anyway.
-KPIC/-call_shared/-non_shared are compatible to native MIPS tools
	(but we could introduce -fPIC/-fno-PIC aliases).

For now, I fixed only the remaining case.


Thiemo


2002-05-30  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>

	/gas/ChangeLog
	* config/tc-mips.c (OPTION_NO_M7000_HILO_FIX): Rename to
	OPTION_MNO_7000_HILO_FIX. Add alternate "mno-fix7000"
	command line switch conforming to gcc conventions.
	* doc/c-mips.texi: Document -mno-fix7000 instead of no-mfix-7000.


diff -BurpN source-orig/gas/config/tc-mips.c source/gas/config/tc-mips.c
--- source-orig/gas/config/tc-mips.c	Thu May 30 19:56:33 2002
+++ source/gas/config/tc-mips.c	Fri May 31 00:19:45 2002
@@ -9840,8 +9986,9 @@ struct option md_longopts[] =
   {"no-mips16", no_argument, NULL, OPTION_NO_MIPS16},
 #define OPTION_M7000_HILO_FIX (OPTION_MD_BASE + 15)
   {"mfix7000", no_argument, NULL, OPTION_M7000_HILO_FIX},
-#define OPTION_NO_M7000_HILO_FIX (OPTION_MD_BASE + 16)
-  {"no-fix-7000", no_argument, NULL, OPTION_NO_M7000_HILO_FIX},
+#define OPTION_MNO_7000_HILO_FIX (OPTION_MD_BASE + 16)
+  {"no-fix-7000", no_argument, NULL, OPTION_MNO_7000_HILO_FIX},
+  {"mno-fix7000", no_argument, NULL, OPTION_MNO_7000_HILO_FIX},
 #define OPTION_FP32 (OPTION_MD_BASE + 17)
   {"mfp32", no_argument, NULL, OPTION_FP32},
 #define OPTION_GP32 (OPTION_MD_BASE + 18)
@@ -10249,7 +10408,7 @@ md_parse_option (c, arg)
       mips_7000_hilo_fix = true;
       break;
 
-    case OPTION_NO_M7000_HILO_FIX:
+    case OPTION_MNO_7000_HILO_FIX:
       mips_7000_hilo_fix = false;
       break;
 
diff -BurpN source-orig/gas/doc/c-mips.texi source/gas/doc/c-mips.texi
--- source-orig/gas/doc/c-mips.texi	Thu Mar 21 16:59:03 2002
+++ source/gas/doc/c-mips.texi	Fri May 31 00:39:49 2002
@@ -106,7 +106,7 @@ This tells the assembler to accept MIPS-
 @samp{-no-mips3d} turns off this option.
 
 @item -mfix7000
-@itemx -no-mfix7000
+@itemx -mno-fix7000
 Cause nops to be inserted if the read of the destination register
 of an mfhi or mflo instruction occurs in the following two instructions.