add MDMX support to binutils.

[cgd@broadcom.com]

At 24 May 2002 11:34:14 -0700, Eric Christopher wrote:
> > @@ -7584,11 +7596,17 @@ validate_mips_insn (opc)
> >        case 'L': break;
> >        case 'M':	USE_BITS (OP_MASK_CCC,		OP_SH_CCC);	break;
> >        case 'N':	USE_BITS (OP_MASK_BCC,		OP_SH_BCC);	break;
> > +      case 'O':	USE_BITS (OP_MASK_ALN,		OP_SH_ALN);	break;
> > +      case 'Q':	USE_BITS (OP_MASK_VSEL,		OP_SH_VSEL);
> > +		USE_BITS (OP_MASK_FT,		OP_SH_FT);	break;
> 
> Formatting. :)

OK, uh, which _is_ the right formatting here?

These are all:

	spaces word tab additional_words tab tab word tab break;

I/we tried to keep that going, except instead of 'spaces word' i used
'tab', since ... well, 'spaces tab'?  8-)

Should I copy the style of tabbing/spacing from the 'U' entry, or
... what?  (IMO it makes less sense than what we did, but you're the
boss...  8-)


> 
> > +      case 'X':	USE_BITS (OP_MASK_FD,		OP_SH_FD);	break;
> > +      case 'Y':	USE_BITS (OP_MASK_FS,		OP_SH_FS);	break;
> > +      case 'Z':	USE_BITS (OP_MASK_FT,		OP_SH_FT);	break;
> 
> Do you need to use these or can you reuse?

by reuse, do you mean add additional 'case's that fall through to D,
S, and T?

(definitely need new letters, can't just re-use D, S, T else the $vN
reg names don't work.)


> Otherwise good and OK provided your co-author has submitted the proper
> forms :)

We both did at the same time, and AFAIK both were approved at the same
time.  If you can check to be sure, that'd be great.  8-)


> Can you submit a quick patch to gcc that adds the command line option
> and passes it to the assembler?

OK, but after this goes in.  8-)

(It was on my list, but my list is long, I'll bump it up.)



chris