PATCH: Fix visibility for MIPS (Re: 2 problems with ELF visibility)

[Daniel Jacobowitz]

On Fri, May 03, 2002 at 12:55:05PM -0700, H . J . Lu wrote:
> On Thu, Apr 25, 2002 at 08:39:54AM -0700, H . J . Lu wrote:
> > On Thu, Apr 25, 2002 at 02:18:18PM +0930, Alan Modra wrote:
> > > On Wed, Apr 24, 2002 at 10:57:57AM -0700, H . J . Lu wrote:
> > > > On Wed, Apr 24, 2002 at 11:53:06PM +0930, Alan Modra wrote:
> > > > > On Mon, Apr 22, 2002 at 12:44:47PM -0700, H . J . Lu wrote:
> > > > > > I am enclosing a patch here. Any comments?
> > > > > > 
> > > > > > 	* elfxx-mips.c (mips_elf_link_hash_entry): Add forced_local.
> > > > > > 	(mips_elf_link_hash_newfunc): Initialize forced_local to false.
> > > > > > 	(mips_elf_record_global_got_symbol): Call _bfd_mips_elf_hide_symbol
> > > > > > 	to hide a global symbol.
> > > > > > 	(_bfd_mips_elf_hide_symbol): Return if forced_local is true. Set
> > > > > > 	forced_local to true. 
> > > > > 
> > > > > The idea seems reasonable, but why can't you use ELF_LINK_FORCED_LOCAL
> > > > > instead of using a new flag?
> > > > 
> > > > Here is a patch which does that.
> > > 
> > > I prefer your first patch.  We ought to avoid adding extra back end
> > > hooks where possible.  BTW, I wasn't trying to say that using a new
> > > flag was bad in itself, just that it seemed at first glance to be
> > > duplicating an existing flag.
> > 
> > Me too. That was my thought too.
> 
> I checked in my first patch. It should only affect glibc in CVS.

Merged to 2.12.1, hopefully correctly.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer