[PATCH RFA] slight tweak to MIPS macro generation.

cgd@broadcom.com cgd@broadcom.com
Mon Mar 18 19:10:00 GMT 2002


On thinking about it some more, it seems ... insane to think that a
macro will ever generate MIPS-3D (or other 'similar ASE' instructions,
for that matter), and it can be quite painful to handle their opcode
formats types in macro_build...

So, don't allow it, and add a comment explaining.


chris
===================================================================
2002-03-18  Chris G. Demetriou  <cgd@broadcom.com>

	* config/tc-mips.c (macro_build): Do _not_ allow MIPS-3D
	instructions to be generated by macros.

Index: config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.114
diff -u -p -r1.114 tc-mips.c
--- tc-mips.c	2002/03/18 18:56:18	1.114
+++ tc-mips.c	2002/03/19 03:06:35
@@ -2901,12 +2901,11 @@ macro_build (place, counter, ep, name, f
   /* Search until we get a match for NAME.  */
   while (1)
     {
+      /* It is assumed here that macros will never generate 
+         MIPS-3D instructions.  */
       if (strcmp (fmt, insn.insn_mo->args) == 0
 	  && insn.insn_mo->pinfo != INSN_MACRO
-	  && OPCODE_IS_MEMBER (insn.insn_mo,
-			       (mips_opts.isa
-	      		        | (mips_opts.ase_mips3d ? INSN_MIPS3D : 0)),
-			       mips_arch)
+	  && OPCODE_IS_MEMBER (insn.insn_mo, mips_opts.isa, mips_arch)
 	  && (mips_arch != CPU_R4650 || (insn.insn_mo->pinfo & FP_D) == 0))
 	break;
 



More information about the Binutils mailing list