obj_coff vs section_hash

[Alan Modra]

On Mon, Jan 21, 2002 at 07:20:49PM -0500, DJ Delorie wrote:
> 
> This was causing multiple .stabstr sections, which makes the cygwin
> linker core.  Since we have no way of either checking for these cases

I'm surprised that this didn't cause a problem before now.  section->name
isn't copied either.

> in subseg_get or letting the caller say whether the string should be
> copied or not, perhaps we should (instead of this patch) be
> conservative and pass "true" for the copy parameter in
> section_hash_lookup in bfd/section.c?

I think fixing the callers of subseg_get is best, at least until
you're sure that nothing compares string pointers.  ;)

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre