Missing variable 'pe_data_import_dll'

[Charles Wilson]

Charles Wilson wrote:

>  > Hi Paul,
>  >
>  > Your recent patch to ld/pe-dll.c:
>  >
>  > 2001-08-02  Paul Sokolovsky  <paul.sokolovsky@technologist.com>
>  >
> 
> 
> This patch originated with Paul; however, I and others modified it
> significantly before it was accepted into binutils CVS.
> 
> 
>  >
>  > created a reference to an external variable called: 'pe_data_import_dll'
>  >  in the function pe_create_import_fixup().
> 
> 
> Ah.  but this particular variable (which started life as
> "data_import_dll") originated in a part of the code which was carried
> unchanged from Paul's original.  So, it is correct that questions about
> this should be directed to Paul...but I'll elaborate below.
> 
> 
>  > Unfortunately this new variable does not appear to be defined anywhere!
>  >   (At least it was not defined when I tried to build the arm-epoc-pe
>  >  target today).
> 
> 
> It is defined in emultempl/pe.em.  From my personal "auto-import STATUS"
> list:
> 
>  > 1. make pe_data_import_dll static? No, used in both pe.em and
>  > pe-dll.c. But why? Is this really necessary -- it sure is ugly. Can
>  >  we fix it?
> 


This is an attempt to improve the situation w.r.t. this shared data 
between pe.em and pe-dll.c.  It works as expected on cygwin, but can 
somebody on a non-DLL, pei386 platform (like arm-epoc-pe) give this a shot?

--Chuck