i386 gas is broken

Alan Modra amodra@bigpond.net.au
Mon Nov 5 13:45:00 GMT 2001


On Thu, Nov 15, 2001 at 04:04:10AM -0500, Hans-Peter Nilsson wrote:
> On Thu, 15 Nov 2001, Alan Modra wrote:
> > 2001-11-12  Nick Clifton  <nickc@cambridge.redhat.com>
> >
> > 	* frags.c (frag_grow): Use frag_make_room() to grow the
> > 	obstack.
> >
> > Reverting this seems to cure all the problems.
> 
> That change looks bogus.  IIUC, frag_make_room will make a new
> chunk when there's no room, and frag_now->fr_fix will be very
> wrong for the "growth".

The trouble is that we keep pointers to the chunk, and within the
chunk.  They all must be updated when realloc'ing.

I'll commit the revert.

Alan



More information about the Binutils mailing list