ppc gas negative line number patch
Nick Clifton
nickc@cambridge.redhat.com
Mon May 28 02:30:00 GMT 2001
Hi Tom,
Thanks for submitting this patch.
> + 2000-05-24 Tom Rix <trix@redhat.com>
> +
> + * config/obj-coff.c : (add_lineno) xcoff allows negative line
> + numbers
> + * config/tc-ppc.c (ppc_stabx) : fix generated symbol
> +
Please submit ChangeLog entries as plain text, not context diffs.
> ! if (S_GET_STORAGE_CLASS (sym) == C_STSYM) {
> !
> symbol_get_tc (sym)->within = ppc_current_block;
>
> + /*
> + In this case :
> +
> + .bs name
> + .stabx "z",arrays_,133,0
> + .es
> +
> + .comm arrays_,13768,3
> +
> + resolve_symbol_value will copy the exp's "within" into sym's when the
> + offset is 0. Since this seems to be corner case problem,
> + only do the correction for storage class C_STSYM. A better solution
> + would be to have the tc field updated in ppc_symbol_new_hook.
> +
> + */
> +
> + if (exp.X_op == O_symbol) {
> + symbol_get_tc (exp.X_add_symbol)->within = ppc_current_block;
> + }
> + }
> +
The formatting of the comment and the if statements is incorrect.
Please fix the above problem, and then consider the patch approved.
Cheers
Nick
More information about the Binutils
mailing list