[PATCH] ARC handling of LD and ST instructions
Nick Clifton
nickc@cambridge.redhat.com
Fri Jun 22 01:50:00 GMT 2001
Hi Stacey,
> This patch does the following things:
>
> - Cleans up handling of the 'c' register in the ST opcode by removing
> overloading of that token during parsing.
> - Adds (missing) handling of:
> ld reg, [val]
> where val is shimm, rather than limm.
> EVEN shimm values are encoded as: ld reg, [val/2, val/2]
> ODD shimm values are encoded as a 64b: ld reg, [limm]
>
> Note: my version 1.1.1.1 corresponds to the binutils-010604 snapshot.
>
> Let me know if there are any problems with this patch.
There are a couple of problems with this patch:
1. No ChangeLog entry. [Please submit this as plain next, not a
context diff].
2. GNU Formatting style not followed in the comments. [Treat them
as real sentances, start with a capital letter. End with a full
stop followed by two spaces].
and the one that actually matters:
3. The GAS ARC testsuite fails with your patch applied:
.../gas/testsuite/gas/arc/st.s: Assembler messages:
.../gas/testsuite/gas/arc/st.s:17: Warning: operand out of range (80 not between -32 and 31)
.../gas/testsuite/gas/arc/st.s:17: Error: unresolved expression that must be resolved
FAIL: gas/arc/st
If you can fix these problems I will be happy to review your patch
again.
Cheers
Nick
More information about the Binutils
mailing list