Why run the windres test on Linux?

H . J . Lu hjl@lucon.org
Tue Jul 24 11:51:00 GMT 2001


On Tue, Jul 24, 2001 at 02:21:58PM -0400, DJ Delorie wrote:
> 
> > > You could just ignore the windres errors if you don't care about them.
> > 
> > Can you mark them xfail on Linux?
> 
> I could.  If you wish to patch it yourself, consider such a patch
> pre-approved.

Here is a patch. Is this OK?

Thanks.


H.J.
----
2001-07-24  H.J. Lu  <hjl@gnu.org>

	* binutils-all/windres/windres.exp: Set xfail on none-ix86/pe
	targets.

Index: binutils-all/windres/windres.exp
===================================================================
RCS file: /work/cvs/gnu/binutils/binutils/testsuite/binutils-all/windres/windres.exp,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 windres.exp
--- binutils-all/windres/windres.exp	2001/07/23 22:05:25	1.1.1.1
+++ binutils-all/windres/windres.exp	2001/07/24 18:49:14
@@ -23,6 +23,14 @@ if {![istarget "i*86-*-*"]} {
     return
 }
 
+if {![istarget "i*86-*-*pe*"] \
+    && ![istarget "i*86-*-cygwin*"] \
+    && ![istarget "i*86-*-mingw32*"] } {
+    set target_xfail "yes"
+} else {
+    set target_xfail "no"
+}
+
 if {![info exists WINDRES]} then {
     return
 }
@@ -68,6 +76,10 @@ foreach res $res_list {
 	}
     }
 
+    if { "$broot" != "bmpalign" && "$target_xfail" == "yes" } {
+	setup_xfail *-*
+    }
+
     verbose "$wr -I rc -O res $res tmpdir/$broot.res" 1
     catch "exec $wr -I rc -O res $res tmpdir/$broot.res" err
 
@@ -96,6 +108,10 @@ foreach res $res_list {
     }
     if { $done != 0 } {
 	continue;
+    }
+
+    if { "$target_xfail" == "yes" } {
+	setup_xfail *-*
     }
 
     verbose "$OBJDUMP -b binary -s tmpdir/$broot.res > tmpdir/$broot.dump" 1



More information about the Binutils mailing list