windres bug.
DJ Delorie
dj@redhat.com
Mon Jul 16 11:14:00 GMT 2001
> binutils/configure: to allow '--with-windres' to be specified as an
> option.
What targets need this but don't do it automatically?
> --- binutils-2.11.2/binutils/configure Mon Jun 11 06:04:27 2001
> +++ binutils-2.11.2.new/binutils/configure Sun Jul 8 08:42:34 2001
The patch should be for configure.in. Configure is generated from
that.
> + /* align header_size to a DWORD boundry. */
> + reshdr.header_size += reshdr.header_size % 4;
This is not the correct math - if header_size is 3, for example, you
end up with a header_size of 6. I think you want this:
sz = (sz + 3) & ~3;
Looks like res_align_file is broken that way too. We probably never
trip over this (because header_size is always a multiple of two), but
better safe than sorry.
More information about the Binutils
mailing list