[PATCH] basename buffer gets spammed in `ld'

H . J . Lu hjl@lucon.org
Sat Jul 14 09:47:00 GMT 2001


On Sat, Jul 14, 2001 at 09:39:34AM -0700, David O'Brien wrote:
> > 
> > > > basename() calls needed to be wrapped with xstrdup it appeared to me this
> > > > basename() call was wrapped in xstrdup for the same reason.
> > > 
> > 
> > I don't like such kind of change. Unless it is broken, don't fix
> > it :-).
> 
> The current code is broken (ie, has bugs that are biting FreeBSD users).

My comment was for the xstrdup change, which is not broken. If you go
back, you can see it is the part of your patch we are discussing. 


H.J.



More information about the Binutils mailing list