Your patch on 2001-01-26 is bad

H . J . Lu hjl@valinux.com
Thu Feb 8 17:53:00 GMT 2001


On Thu, Feb 08, 2001 at 04:28:52PM -0800, Richard Henderson wrote:
> On Wed, Feb 07, 2001 at 12:22:58PM -0800, H . J . Lu wrote:
> > Before you change it back, please get the current glibc from CVS and
> > build/check on both ia64 and alpaha. You should run the ELF visibility
> > test in ld/testsuite also.
> 
> The following passes the glibc and ld tests.
> 
> There were two problems with my original change:
> 
>   * Apparently the ld testsuite has decreed that weak overrides
>     hidden.  This is contrary to my intuition, but I guess I'll
>     go along with it for now.
> 

Can you elaborate on that? I wrote the ld visibility tests. I couldn't
find what you claimed. It doesn't make much sense to have weak and
hidden definition. I didn't test it.


H.J.



More information about the Binutils mailing list