Merging of various patches for d10v gas
Alan Matsuoka
alanm@cygnus.com
Tue Dec 18 06:01:00 GMT 2001
On Tue, 18 Dec 2001, Nick Clifton wrote:
> Hi Alan,
>
> > The following patches are from various fixes that have been
> > floating around and have not been merged back into the head.
>
> This patch appears to contain a lot of redundant and incorrect
> changes.
>
> For example:
>
> > ***************
> > *** 20,31 ****
> > Boston, MA 02111-1307, USA. */
> >
> > #include <stdio.h>
> > #include "as.h"
> > - #include "safe-ctype.h"
> > #include "subsegs.h"
> > #include "opcode/d10v.h"
> > --- 19,29 ----
> > Boston, MA 02111-1307, USA. */
> >
> > #include <stdio.h>
> > + #include <ctype.h>
> > #include "as.h"
> > #include "subsegs.h"
> > #include "opcode/d10v.h"
>
> This is wrong. "safe-ctype.h" should be used in preference to ctype.h
OK.
>
> > *************** int Optimizing = 0;
> > *** 42,48 ****
> > && S_GET_VALUE ((X)->X_op_symbol) == AT_WORD_RIGHT_SHIFT)
> > #define AT_WORD_RIGHT_SHIFT 2
> >
> > ! /* Fixups. */
> > #define MAX_INSN_FIXUPS (5)
> > struct d10v_fixup
> > {
> > --- 40,47 ----
> > && S_GET_VALUE ((X)->X_op_symbol) == AT_WORD_RIGHT_SHIFT)
> > #define AT_WORD_RIGHT_SHIFT 2
> >
> > !
> > ! /* fixups */
> > #define MAX_INSN_FIXUPS (5)
> > struct d10v_fixup
> > {
>
> This is also wrong. It is breaking the conventions for comment
> formatting.
>
>
> Please could you resubmit this patch after removing all the redundant
> or backwards changes and only including the relevant bug fixes and
> improvements.
>
OK. Thanks for the comments. There were so many patches it's hard to see the
forest for the trees. I'll take a run through them and sort it all out.
Alan Matsuoka
GCC Engineering
Red Hat Canada, Ltd
mailto:alanm@redhat.com Tel: (416) 482-2661 x250 / Fax: (416) 482-6299
More information about the Binutils
mailing list