PATCH: Update nm.c for 64bit BFD on 32bit ELF files.

H . J . Lu hjl@lucon.org
Fri Aug 24 16:45:00 GMT 2001


On Fri, Aug 24, 2001 at 07:14:22PM -0400, Andrew Cagney wrote:
> 
> > +  char buf[30];
> >  
> >    if (! dynamic)
> >      {
> > @@ -960,6 +966,9 @@ display_rel_file (abfd, archive_bfd)
> >        return;
> >      }
> >  
> > +  bfd_sprintf_vma (abfd, buf, (bfd_vma) -1);
> > +  print_width = strlen (buf);
> > +
> 
> Hmm, the most popular security hole and a generally popular bug is 
> buffer overrun on the stack.  Is hardwiring a buffer allocated of the 
> stack and then sprintf() into it really a good idea?

We know bfd_sprintf_vma will at most print a 64bit address in hex.


H.J.



More information about the Binutils mailing list