[PATCH] SHF_MERGE fixes

[amodra@one.net.au]

On Fri, Apr 20, 2001 at 05:32:38PM +0200, Jakub Jelinek wrote:
> Ok to commit?

Yes.

> +  mask = ((bfd_vma)1 << align) - 1;
Formatting.

> +	  if (!eltalign || eltalign > mask)
I think this is bad style, and should be written as
	if (eltalign == 0 || eltalign > mask)
simply because the code doesn't read as well in the first form.

For the same reason, I don't particularly like "if (!strcmp (...))",
and other uses of `!' on non-boolean values but have to concede that
this is fairly common idiom.

Alan