bfd/section.c patch
Alan Modra
alan@linuxcare.com.au
Tue Oct 10 08:27:00 GMT 2000
On Tue, 10 Oct 2000, Tom Rix wrote:
> This is a trivial patch to the bfd/section.c file.
Um, don't ever treat bfd_release as trivial. bfd_release calls
libiberty/objalloc.c:objalloc_free_block, which releases all more recently
alloc'd blocks as well as the passed block. You really need to carefully
check all functions called between the bfd_alloc and bfd_release, as
otherwise you might end up with dangling references. After doing some
checking, I think it's OK here though.
> ! bfd_release(abfd, newsect);
There should be a space between the function name and open parenthesis.
Also, please submit ChangeLog entries as plain text rather than diffs.
These rarely apply cleanly.
Thanks, committed.
Alan Modra
--
Linuxcare. Support for the Revolution.
More information about the Binutils
mailing list