// comments

Ralf Baechle ralf@uni-koblenz.de
Tue Oct 3 09:50:00 GMT 2000


On Tue, Oct 03, 2000 at 10:32:59AM -0600, Jeffrey A Law wrote:

>   In message < 20001003173914.A25079@bacchus.dhis.org >you write:
>   > Is there a policy about //-style comments in binutils?  They're a pain in
>   > the ass when building binutils with a not recent compiler or a non-gcc
>   > compiler.

> They are verboten -- if you find any, send a patch to convert them into
> C style comments.

Patch below.

  Ralf

2000-10-03  Ralf Baechle  <ralf@gnu.org>

	* config/tc-ia64.c (operand_match): Convert //-style comments to
	/* */-style.
	* config/tc-i370.c: Likewise.
 
diff -urN binutils-cygnus/gas/config/tc-i370.c binutils/gas/config/tc-i370.c
--- binutils-cygnus/gas/config/tc-i370.c	Thu Sep 14 03:38:34 2000
+++ binutils/gas/config/tc-i370.c	Tue Oct  3 18:40:55 2000
@@ -552,7 +552,7 @@
 }
 
 /* Figure out the BFD architecture to use.  */
-// hack alert -- specify the different 370 architectures
+/* hack alert -- specify the different 370 architectures  */
 
 enum bfd_architecture
 i370_arch ()
@@ -687,9 +687,9 @@
 
   static struct map_bfd mapping[] =
   {
-    //     MAP ("l",        	BFD_RELOC_LO16),
-    //     MAP ("h",        	BFD_RELOC_HI16),
-    //     MAP ("ha",        	BFD_RELOC_HI16_S),
+    /*     MAP ("l",        	BFD_RELOC_LO16), */
+    /*     MAP ("h",        	BFD_RELOC_HI16), */
+    /*     MAP ("ha",        	BFD_RELOC_HI16_S), */
     MAP ("fixup",        BFD_RELOC_CTOR),          /* warnings with -mrelocatable */
     { (char *)0,        0,	BFD_RELOC_UNUSED }
   };
diff -urN binutils-cygnus/gas/config/tc-ia64.c binutils/gas/config/tc-ia64.c
--- binutils-cygnus/gas/config/tc-ia64.c	Sat Sep 23 23:46:23 2000
+++ binutils/gas/config/tc-ia64.c	Tue Oct  3 18:35:51 2000
@@ -7910,7 +7910,7 @@
   else if (strncmp (idesc->name, "br.call", 6) == 0
 	   || strncmp (idesc->name, "brl.call", 7) == 0)
     {
-      // FIXME keep GR values which are marked as "safe_across_calls"
+      /* FIXME keep GR values which are marked as "safe_across_calls"  */
       clear_register_values ();
       clear_qp_mutex (~qp_safe_across_calls);
       clear_qp_implies (~qp_safe_across_calls, ~qp_safe_across_calls);


More information about the Binutils mailing list