Revert my missing version name check patch.
H . J . Lu
hjl@valinux.com
Tue Nov 14 21:46:00 GMT 2000
It turns out that ld/testsuite/ld-elfvers has some tests with code
like
__asm__(".symver original_foo,foo@");
This patch reverts my patch and comments out the related tests :-).
--
H.J. Lu (hjl@valinux.com)
---
2000-11-14 H.J. Lu <hjl@gnu.org>
* config/obj-elf.c (obj_elf_symver): Don't check the missing
version name.
2000-11-14 H.J. Lu <hjl@gnu.org>
* gas/symver/symver.exp: Don't run symver4 nor symver5.
Index: config/obj-elf.c
===================================================================
RCS file: /work/cvs/gnu/binutils/gas/config/obj-elf.c,v
retrieving revision 1.25
diff -u -p -r1.25 obj-elf.c
--- config/obj-elf.c 2000/11/15 04:52:24 1.25
+++ config/obj-elf.c 2000/11/15 05:32:44
@@ -1126,16 +1126,12 @@ obj_elf_symver (ignore)
if (symbol_get_obj (sym)->versioned_name == NULL)
{
- char *p, *rp;
-
symbol_get_obj (sym)->versioned_name = xstrdup (name);
*input_line_pointer = c;
- p = strchr (symbol_get_obj (sym)->versioned_name, ELF_VER_CHR);
- if (p)
- rp = strrchr (p, ELF_VER_CHR);
- if (!p || p [1] == '\0' || rp [1] == '\0')
+ if (strchr (symbol_get_obj (sym)->versioned_name,
+ ELF_VER_CHR) == NULL)
{
as_bad (_("missing version name in `%s' for symbol `%s'"),
symbol_get_obj (sym)->versioned_name,
Index: testsuite/gas/symver/symver.exp
===================================================================
RCS file: /work/cvs/gnu/binutils/gas/testsuite/gas/symver/symver.exp,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 symver.exp
--- testsuite/gas/symver/symver.exp 2000/11/15 04:40:41 1.1.1.1
+++ testsuite/gas/symver/symver.exp 2000/11/15 05:40:04
@@ -42,7 +42,7 @@ if { ([istarget "*-*-elf*"]
run_dump_test "symver1"
run_error_test "symver2" ""
run_error_test "symver3" ""
- run_error_test "symver4" ""
- run_error_test "symver5" ""
+# run_error_test "symver4" ""
+# run_error_test "symver5" ""
run_error_test "symver6" ""
}
More information about the Binutils
mailing list