Patch for --gstabs and packing support in the generic assembler

[Nick Clifton]

Hi Matt,

: 2000-11-06  Matthew Hiller  <hiller@redhat.com>
: 
: 	* as.c (outputting_line_debug_p): New variable.
: 
: 	* as.h (outputting_line_debug_p): New extern declaration.
: 
: 	* stabs.c (stabs_generate_asm_lineno): Sets
: 	outputting_line_debug_p at function entry and unsets at
: 	function exit.

Approved.

A couple of small nits:

  * Please do not separate related notes in a ChangeLog entry with
    blank lines.  It upsets Doug :-)

  * Generally speaking there is no advantage gained by declaring a
    boolean variable as 'unsigned char'.  Either declare it as 'int'
    (which will be faster to access on some architectures) or
    'boolean' (an enum defined in bfd/bfd-in2.h).

  * I think the variable name ought to include 'stabs' in it, to make
    it clear that this is a stabs-only variable.

  * (This is just a personal thing): Postfixing boolean variables with
    'p' really bugs me.  This is not LISP.  It is not even close to
    LISP.  If you are programming in C, then make your variable names
    C-like!  ie, I would have called the variable 'outputting_stabs_line_debug'
    so that it could be tested in an if statement like this:

       if (outputting_stabs_line_debug_p)
          ...

Cheers
	Nick