[patch] binary file endianness

Geoff Keating geoffk@cygnus.com
Sat May 20 18:47:00 GMT 2000


> Date: Sun, 21 May 2000 03:14:18 +0300
> From: Momchil Velikov <velco@fadata.bg>

> This patch fixes ppc_elf_merge_private_data so it
> doesn't give an error if one of the files is a non-ELF one,
> e.g. binary.
> mcore, mips and sh have the same problem.

Shouldn't it instead check to see whether the endianness is unknown?

You still don't want to be linking a little-endian COFF with a
big-endian ELF, I think.

>    /* Check if we have the same endianess */
>    if (ibfd->xvec->byteorder != obfd->xvec->byteorder
>        && obfd->xvec->byteorder != BFD_ENDIAN_UNKNOWN)

Perhaps we need a test for ibfd->xvec->byteorder != BFD_ENDIAN_UNKNOWN.

-- 
- Geoffrey Keating <geoffk@cygnus.com>


More information about the Binutils mailing list