i386 gas patch: scale factor handling improvements

Nick Clifton nickc@cygnus.com
Fri May 19 16:04:00 GMT 2000


Hi Gavin,

: --- 2642,2654 ----
:     return 1;
:   }
:   
: ! 
: ! 
: ! 
: ! static int i386_scale_nowarn PARAMS ((char *));

Is there a reason for the extra blank lines ?



: + 	      if (is_space_char (*temp_string))
: + 		++temp_string;
: + 

Shouldn't this be a while loop, or is it defined that there can only
be one space character between the asterisk and the start of the next
operand ?

 
: Ok to commit?

I will it up to the x86 maintainer to officially approve or deny this
patch.  I have no objections.

Cheers
	Nick


More information about the Binutils mailing list