elf32-mips.c warnings

Nick Clifton nickc@cygnus.com
Tue Jul 18 11:42:00 GMT 2000


Hi Andrew,

: I was going to just post a patch but,
: 
: /home/scratch/ALL/all/bfd/elf32-mips.c: In function
: `_bfd_mips_elf_create_dynamic_sections':
: /home/scratch/ALL/all/bfd/elf32-mips.c:7104: warning: suggest
: parentheses around && within ||
: /home/scratch/ALL/all/bfd/elf32-mips.c: In function
: `_bfd_mips_elf_finish_dynamic_symbol':
: /home/scratch/ALL/all/bfd/elf32-mips.c:8639: warning: suggest
: parentheses around && within ||
: 
: I'm not sure what:
: 
:   if (IRIX_COMPAT (abfd) == ict_irix5 || IRIX_COMPAT (abfd) == ict_none
:       && !info->shared
:       && bfd_get_section_by_name (abfd, ".rld_map") == NULL)
: 
: or:
: 
:       if (! mips_elf_hash_table (info)->use_rld_obj_head
: 	  && strcmp (name, "__rld_map") == 0 || strcmp (name, "__RLD_MAP") == 0)
: 
: should be.

Well judging by the indentation and code I would assume that they
ought to be:

 if ((IRIX_COMPAT (abfd) == ict_irix5 || IRIX_COMPAT (abfd) == ict_none)
     && !info->shared
     && bfd_get_section_by_name (abfd, ".rld_map") == NULL)
and

 if (! mips_elf_hash_table (info)->use_rld_obj_head
   && (strcmp (name, "__rld_map") == 0 || strcmp (name, "__RLD_MAP") == 0))

But I will levae the final word to Ulf.

Cheers
	Nick


More information about the Binutils mailing list