[patch] readelf.c - dump .eh_frame sections

Andrew Haley aph@redhat.com
Thu Dec 7 12:29:00 GMT 2000


DJ Delorie writes:
 > 
 > Hmmm... replicating that big switch statement bothers me, but merging
 > the two would be just as messy support-wise.

Indeed.  I played with both, and the way we end up with duplicated
logic is unpleasant.  I could add a comment saying "BEWARE: if you add
and entry to THAT switch add it to THIS one as well".

 > This method means that different FDE's may have different sets of
 > columns.  Is this intentional? 

Yes, it is.  Some folk may prefer it otherwise.

 > It's probably easier than scanning the whole eh_frame section
 > twice, though.

Quite.  I was really just trying to make it readable, not gold plated!

 > I guess I like it :-)

Good.

Andrew.


More information about the Binutils mailing list