flex or lex required: typo in (source of) binutils/aclocal.m4

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Thu Dec 7 12:20:00 GMT 2000


The generated binutils/configure has this quoting typo:
 test -n "$LEX" || LEX=""$missing_dir/missing flex""
while this is correct, generated from the the patch below:
 test -n "$LEX" || LEX="$missing_dir/missing flex"

This causes configuration errors if lex and flex is missing, a
situation which is otherwise well handled, and works after
applying this patch.

Now, the source to the guilty aclocal.m4 seems to come from
automake.  In the latest cvs version of automake, m4/lex.m4
seems to be corrected, but using new automake infrastructure.  I
don't know what to do in the wider perspective.  Maybe we now
need to require a new snapshot of automake or perhaps there is
another, better correction than what is below.  Meanwhile this
local patch seems useful at least for releases and perhaps is

ok to commit?

binutils:

	* aclocal.m4: Remove quotes for "$missing_dir/missing flex".
	* configure: Regenerate.

Index: aclocal.m4
===================================================================
RCS file: /cvs/src/src/binutils/aclocal.m4,v
retrieving revision 1.5
diff -c -p -r1.5 aclocal.m4
*** aclocal.m4	2000/09/06 00:13:33	1.5
--- aclocal.m4	2000/12/07 19:30:15
*************** dnl AM_PROG_LEX
*** 147,153 ****
  dnl Look for flex, lex or missing, then run AC_PROG_LEX and AC_DECL_YYTEXT
  AC_DEFUN(AM_PROG_LEX,
  [missing_dir=ifelse([$1],,`cd $ac_aux_dir && pwd`,$1)
! AC_CHECK_PROGS(LEX, flex lex, "$missing_dir/missing flex")
  AC_PROG_LEX
  AC_DECL_YYTEXT])
  
--- 147,153 ----
  dnl Look for flex, lex or missing, then run AC_PROG_LEX and AC_DECL_YYTEXT
  AC_DEFUN(AM_PROG_LEX,
  [missing_dir=ifelse([$1],,`cd $ac_aux_dir && pwd`,$1)
! AC_CHECK_PROGS(LEX, flex lex, $missing_dir/missing flex)
  AC_PROG_LEX
  AC_DECL_YYTEXT])
  
brgds, H-P


More information about the Binutils mailing list